Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Html rendering problem when renaming varaibles #1769

Closed
Ran-Naor opened this issue Jan 27, 2023 · 1 comment
Closed

Html rendering problem when renaming varaibles #1769

Ran-Naor opened this issue Jan 27, 2023 · 1 comment
Labels
bug GUI Issues in jadx-gui module

Comments

@Ran-Naor
Copy link
Contributor

When you rename variables the html is printed out as plain text instead of being rendered.
The solution is to just override the disableHtml function in the JVariable class to return false.

before fix:
before
after fix:
after

I will add the PR of the simple fix.
@Ran-Naor Ran-Naor mentioned this issue Jan 27, 2023
Merged
skylot pushed a commit that referenced this issue Jan 27, 2023
@Ran-Naor
fix(gui): allow html in JVariable to render renaming of variables cor…
2d149e9 
…rectly (#1769)(PR #1770)
@skylot
Copy link
Owner

skylot commented Jan 27, 2023

@Ran-Naor PR merged. Thank you for the fix!

@skylot skylot closed this as completed Jan 27, 2023
@skylot skylot added bug GUI Issues in jadx-gui module and removed new feature labels Jan 27, 2023
@anantshri anantshri mentioned this issue Feb 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug GUI Issues in jadx-gui module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skylot @Ran-Naor