Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: jadx-gui-0.8.0.exe can't be placed in the Open With context menu #377

Closed
jpstotz opened this issue Oct 24, 2018 · 3 comments
Closed

Comments

@jpstotz
Copy link
Collaborator

jpstotz commented Oct 24, 2018

On Windows 10 I tried to add the jadx-gui-0.8.0.exe in the Open With list of APK files.

However it does not matter what I do Jad-X never appears in this context menu even if it you do open an APK using jadx-gui-0.8.0.exe once. Other apps then appear in the open with context menu, but not JadX.
Really strange. There must be something different/wrong with the jadx-gui-0.8.0.exe that prevents Windows from displaying it in the open with list.

@jpstotz
Copy link
Collaborator Author

jpstotz commented Oct 28, 2018

I searched the net for this problem and found many similar issues in other applications.

It seems to be a problem with Windows 10 and the included app meta data in the EXE file. WIndows seems to assume that every EXE file has at least CompanyName and a FileDescription entry that is not empty.

For jad-x this means that the launch4j configuration options should include a companyName = "....." entry. It seems like the FileDescription is automatically added by launch4j. In my personal build it worked after adding the comanyName line.

I would provide a pull request, but I have to admit that I don't have a clue what we should set as companyName for an open source software like jad-x.

In my tests I used companyName = "Open Source Software (Apache License 2.0)"

Any comments or other suggestions?

@skylot
Copy link
Owner

skylot commented Oct 28, 2018

@jpstotz I think just jadx as CompanyName is fine. Thanks for solving this!

jpstotz added a commit to jpstotz/jadx that referenced this issue Oct 28, 2018
jpstotz added a commit to jpstotz/jadx that referenced this issue Oct 28, 2018
@jpstotz
Copy link
Collaborator Author

jpstotz commented Oct 28, 2018

OK. Change is included in pull request #379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants