String constructor with byte array

[asashour]

As deduced from #529, there is also a potential to make String constructor beautiful.

	public static class TestCls {
		public String tag = new String(new byte[] {'a', 'b', 'c'});
	}

	@Test
	public void test() {
		ClassNode cls = getClassNode(TestCls.class);
		String code = cls.getCode().toString();

		assertThat(code, containsOne("abc"));
	}

[asashour]

I am trying to fix this, but I counter an issue, the corresponding output could be something like:

new String("abc".getBytes(), StandardCharsets.UTF_8);

And I don't know how to construct a MethodInfo of the String(byte[]) constructor if it is not found in dex.

[skylot]

Looks like you need to implement it youself. Add to MethodInfo class something like this:

public static MethodInfo externalMth(ClassInfo declaredCls, String name, List<ArgType> args, ArgType retType) {

[bagipro]

Seems that it would be better to begin from constant concatenations like

String value = "a" + "b";

sometimes "a" could be a static final String SMTH = "a"; value, and when --no-replace-consts option is enabled, the given output will be generated. But it's nicer to see

String value = "ab";

[asashour]

Seems that it would be better to begin from constant concatenations like

String value = "a" + "b";

sometimes "a" could be a static final String SMTH = "a"; value, and when --no-replace-consts option is enabled, the given output will be generated. But it's nicer to see

String value = "ab";

I guess this is a different case, since constants are usually String, but the one is question is a byte array.