Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to disable "renaming" #570

Closed
skylot opened this issue Apr 8, 2019 · 2 comments · Fixed by #582
Closed

Add options to disable "renaming" #570

skylot opened this issue Apr 8, 2019 · 2 comments · Fixed by #582
Labels
CLI Issues in jadx-cli module Core Issues in jadx-core module enhancement GUI Issues in jadx-gui module
Milestone

Comments

@skylot
Copy link
Owner

skylot commented Apr 8, 2019

This issue discussion started in #158.
Sometimes it is useful to view names "as-is" without any modifications.
So jadx must have an option for that.

For now, jadx has many "renaming" types besides deobfuscation:

  • to support system case sensitivity
  • to make valid java identifiers (to make code compilable)
  • to remove not "printable" characters
    "printable" - here means only Latin chars (32 to 126 codes in ascii table)

Options must allow to disable/enable such types separately:

  • In JadxArgs it must be enum set (full set is default)
  • In jadx-cli list of lower case enum names with comma separator, plus shortcuts like all and none
    Examples: --rename-flags case,valid,printable or --rename-flags all
  • In jadx-gui in must be several checkboxes under common label.
    And if some options is disabled before source export warning notification about changing names can be shown.
@skylot skylot added CLI Issues in jadx-cli module Core Issues in jadx-core module enhancement GUI Issues in jadx-gui module labels Apr 8, 2019
@skylot skylot added this to the 1.0.0 milestone Apr 8, 2019
@asashour
Copy link
Contributor

Should these settings apply to fields and methods as well?

@skylot
Copy link
Owner Author

skylot commented Apr 11, 2019

@asashour yes, this must be done for fields and methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI Issues in jadx-cli module Core Issues in jadx-core module enhancement GUI Issues in jadx-gui module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants