Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Missing catch/finally statement for try #703

Closed
bagipro opened this issue Jul 9, 2019 · 3 comments
Closed

[core] Missing catch/finally statement for try #703

bagipro opened this issue Jul 9, 2019 · 3 comments
Labels
bug Core Issues in jadx-core module

Comments

@bagipro
Copy link
Collaborator

bagipro commented Jul 9, 2019

Checks before report

  • [+] check latest unstable build (maybe issue already fixed)
  • [+] search existing issues by exception message
    (for example JadxRuntimeException: Can't find immediate dominator for block)
  • [+] check Troubleshooting Q&A section on wiki

Describe error
Class com.paypal.android.p2pmobile.wallet.BaseWalletHandles

    public com.paypal.android.p2pmobile.wallet.managers.IWalletOperationManager getWalletOperationManager() {
        synchronized (com.paypal.android.p2pmobile.wallet.WalletModel.class) {
            try {
                if (this.mWalletOperationManager == null) {
                    this.mWalletOperationManager = com.paypal.android.p2pmobile.wallet.managers.WalletOperationManager.newInstance();
                }
            } // the rest is missing
        }
        return this.mWalletOperationManager;
    }

APK: https://drive.google.com/file/d/1CSo_sZ71WsM3WvGw2VzG7xnkqpUO3GSJ/view?usp=sharing

@bagipro bagipro added bug Core Issues in jadx-core module labels Jul 9, 2019
@bagipro
Copy link
Collaborator Author

bagipro commented Jul 9, 2019

Could be more simple example com.paypal.android.p2pmobile.p2p.common.eligibility.EligibilityCache

    public synchronized com.paypal.android.p2pmobile.p2p.common.eligibility.EligibilityResult getEligibilityResult() {
        try {
        }
        return this.mEligibilityResult;
    }

@bagipro
Copy link
Collaborator Author

bagipro commented Jul 22, 2019

@skylot
Can you please prioritize this one? It corrupts code inside try statement :(

@skylot
Copy link
Owner

skylot commented Jul 22, 2019

Fixed. I hope :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Core Issues in jadx-core module
Projects
None yet
Development

No branches or pull requests

2 participants