-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Constructor and super constructor invocations should be first statements (update) #704
Comments
@skylot protected ActivityDetailsRetrieveOperation(ActivityItem.Id id, ActivityDetailsRequestParamsHelper activityDetailsRequestParamsHelper) {
// StringBuilder sb = new StringBuilder();
// sb.append("activity-details/");
// sb.append(id.getValue());
super(sb.toString(), ActivityItem.class, activityDetailsRequestParamsHelper);
this.f13703a = id.getActivityType();
} it could be changed to super("activity-details/" + id.getValue(), ActivityItem.class, activityDetailsRequestParamsHelper); or super(new StringBuilder().append("activity-details/").append(id.getValue()).toString(), ActivityItem.class, activityDetailsRequestParamsHelper); |
And also variable declarations are still kept before constructor calls, file public MutableDataObject(android.os.Parcel parcel) {
org.json.JSONObject jSONObject;
org.json.JSONObject jSONObject2;
this(); |
All cases fixed. |
Checks before report
(for example
JadxRuntimeException: Can't find immediate dominator for block
)Describe error
Original thread: #685
Can you place (super) constructor call on the first place? I've noticed that anonymous classes are changed to inner classes, but used external variables are not accessible anymore. Example (class
com.paypal.android.p2pmobile.wallet.common.fragments.ThreeDsWebViewFragment$C35854
)APK: https://drive.google.com/file/d/1CSo_sZ71WsM3WvGw2VzG7xnkqpUO3GSJ/view?usp=sharing
The text was updated successfully, but these errors were encountered: