Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

very slow after opening class that have big byte array #714

Closed
MrPooyaX opened this issue Jul 18, 2019 · 8 comments
Closed

very slow after opening class that have big byte array #714

MrPooyaX opened this issue Jul 18, 2019 · 8 comments

Comments

@MrPooyaX
Copy link

some APK's (and // protected by DexProtector) in decryptions class have very big byte array.
if i want to open this class with jadx, It freezes
you can check class "co.palang.QuizOfKings.ProtectedCoronaApplication" in QuizOfKings game(download from googleplay)

@jpstotz
Copy link
Collaborator

jpstotz commented Jul 18, 2019

If the UI is not capable of handling such large data you can still decompile the APK to sources using jadx on the command-line.

Afterwards you can check if any of your editors is capable to display the large files.

@MrPooyaX
Copy link
Author

@jpstotz i did what you said, open this class with Notepad++ not freezes my pc, just little slow, on scrolling.
but jadx fully freeze

@jpstotz
Copy link
Collaborator

jpstotz commented Jul 18, 2019

The common Java UI components are not designed to handle extreme situations. This applies to most Java AWT/Swing gui components as well as SWT components.

Therefore Jadx can only use or not use those components. Furthermore exchanging central components like the source code viewer would cause significant amount of time as a lit of jadx functionality depends upon it.

If you are a Java developer feel free to make your own tests and provide improvements to jadx and/or any of the components Jadx uses (like RSyntaxTextArea which is used a source code viewer).

@skylot
Copy link
Owner

skylot commented Jul 18, 2019

I just run the profiler and found that problem in line numbers rendering. Then disabled, code viewer works fine and not freeze. And that not RSyntaxTextArea fault, this component was added by me :(
I will try to optimize it or adjust condition to disable it as I did previously here.

@MrPooyaX
Copy link
Author

Thank you, good luck

@skylot
Copy link
Owner

skylot commented Jul 18, 2019

Fixed! Can anyone check the latest build to confirm the fix?

@JorgeTebruski
Copy link

Now works fine.

@MrPooyaX
Copy link
Author

Yeeah works fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants