Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] BinaryXMLParser injects xmlns: from other files on load #796

Closed
S-trace opened this issue Dec 12, 2019 · 1 comment
Closed

[core] BinaryXMLParser injects xmlns: from other files on load #796

S-trace opened this issue Dec 12, 2019 · 1 comment
Labels
bug Core Issues in jadx-core module

Comments

@S-trace
Copy link
Contributor

S-trace commented Dec 12, 2019

Checks before report

  • check latest unstable build (maybe issue already fixed)
    Not fixed
  • check Troubleshooting Q&A section on wiki
    Not out-of-memory problem.
  • search existing issues by exception message
    No exception message.

Describe error

  • provide full name of method or class with error
    Not method.

  • provide full java stacktrace
    No stacktrace.
    Note: no need to copy method fallback code (commented pseudocode)

  • attach or provide link to apk file (double check apk version)
    res.apk.zip

    Note: GitHub don't allow attach files with .apk extension, but you can change extension by adding .zip at the end :)

Hello.

jadx-gui injects xmlns: attribute from another XML files to newly opened files, even if this xmlns: is not present in the opened file.

To check:

  1. Open attached apk, open abc_fade_in.xml, copy its content to compare tool
  2. Close jadx-gui
  3. Open attached apk, open avd_show_password.xml then open abc_fade_in.xml, copy its content to compare tool
  4. Compare abc_fade_in.xml content from both times, take a note about xmlns:aapt appeared

I pushed a fix to https://github.com/S-trace/jadx/tree/nsmap_reset
@skylot Could you please review it and allow me to open a pull request?

Thank you.

@S-trace S-trace added Core Issues in jadx-core module bug labels Dec 12, 2019
@skylot
Copy link
Owner

skylot commented Dec 13, 2019

@S-trace what is a good catch, thanks! Please open PR.

P.S. Next time if you already made a fix for some new issue just open PR. By line from contributiong guide:

Before open a PR please discuss the change you wish to make via issue. PR without corresponding issue will be rejected.

I mean it is better to discuss change before starting working on this change especially if it is big.
So if you already implement the fix you can just open PR without asking my permission :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Core Issues in jadx-core module
Projects
None yet
Development

No branches or pull requests

2 participants