Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Small app is decompiled within long time #846

Closed
bagipro opened this issue Feb 4, 2020 · 1 comment
Closed

[core] Small app is decompiled within long time #846

bagipro opened this issue Feb 4, 2020 · 1 comment
Labels
bug Core Issues in jadx-core module

Comments

@bagipro
Copy link
Collaborator

bagipro commented Feb 4, 2020

APK: https://drive.google.com/file/d/1MC4DiEojEOLGqKKzt3mspD8jMYQtrBe3/view?usp=sharing

jstack shows the following output

   java.lang.Thread.State: RUNNABLE
	at java.util.BitSet.and(java.base@13.0.1/BitSet.java:921)
	at jadx.core.utils.BlockUtils.calcPartialPostDominance(BlockUtils.java:713)
	at jadx.core.utils.BlockUtils.calcPartialImmediatePostDominator(BlockUtils.java:750)
	at jadx.core.dex.visitors.regions.RegionMaker.calcPostDomOut(RegionMaker.java:869)
	at jadx.core.dex.visitors.regions.RegionMaker.processSwitch(RegionMaker.java:761)
	at jadx.core.dex.visitors.regions.RegionMaker.traverse(RegionMaker.java:130)
	at jadx.core.dex.visitors.regions.RegionMaker.makeRegion(RegionMaker.java:88)
	//...

Maybe there is an error preventing it from being decompiled much faster?

@bagipro bagipro added bug Core Issues in jadx-core module labels Feb 4, 2020
@skylot
Copy link
Owner

skylot commented Feb 16, 2020

Fixed. The cause was a new switch processing method implemented in #826. I add some additional checks to skip not relevant paths, this makes decompilation much faster in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Core Issues in jadx-core module
Projects
None yet
Development

No branches or pull requests

2 participants