Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Use of useless casts #962

Closed
bagipro opened this issue Aug 10, 2020 · 1 comment
Closed

[core] Use of useless casts #962

bagipro opened this issue Aug 10, 2020 · 1 comment
Assignees
Labels
bug Core Issues in jadx-core module
Milestone

Comments

@bagipro
Copy link
Collaborator

bagipro commented Aug 10, 2020

Class com.ebay.nautilus.domain.data.experience.onboarding.OnboardingAnswer

    @Override // com.ebay.nautilus.domain.data.experience.type.field.Field
    public void setSelected(boolean z) {
        ((com.ebay.nautilus.domain.data.experience.type.field.Field) this).selected = z;
    }

In this case, the cast is useless (and there are tons of them), this.selected can be used instead

APK: https://drive.google.com/file/d/1qC3tlWs9AtPBpyS6iU9kcSphLryfJOxi/view?usp=sharing

@bagipro bagipro added bug Core Issues in jadx-core module labels Aug 10, 2020
@skylot skylot added this to the v1.2.0 milestone Sep 6, 2020
@skylot skylot self-assigned this Sep 6, 2020
skylot added a commit that referenced this issue Sep 7, 2020
@skylot
Copy link
Owner

skylot commented Sep 7, 2020

@sergey-wowwow I made a fix ... and commit has many different changes, so new issues are expected :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Core Issues in jadx-core module
Projects
None yet
Development

No branches or pull requests

2 participants