Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Android App Bundle support #1131

Merged
merged 7 commits into from
Mar 8, 2021
Merged

Implement Android App Bundle support #1131

merged 7 commits into from
Mar 8, 2021

Conversation

bagipro
Copy link
Collaborator

@bagipro bagipro commented Mar 7, 2021

❗ Please review the guidelines for contributing

Description

@skylot
Please provide instructions again on how to format code before committing :)

Currently implemented support for XML files, also have to finish resource tables

@skylot
Copy link
Owner

skylot commented Mar 7, 2021

Please provide instructions again on how to format code before committing :)

Check code formatting guide. In short, you just need to run

gradle spotlessApply 

Anyway, I already applied these formatting fixes 😃

@skylot
Copy link
Owner

skylot commented Mar 7, 2021

@bagipro I reviewed the changes and everything is good.
And here is a small list for future improvements:

  • detect proto xml by file content (starting bytes or similar)
  • support other .pb resources:
    • resources.pb
    • assets.pb
    • BundleConfig.pb
    • dependencies.pb - can help to restore dependencies for gradle export 😄

@bagipro
Copy link
Collaborator Author

bagipro commented Mar 8, 2021

@skylot
May you please check the PR and merge it? I need to update my tool and then research what to do with other .pb files

@skylot skylot merged commit 9ef99a2 into master Mar 8, 2021
@skylot skylot deleted the impl_aab branch March 8, 2021 18:34
@skylot
Copy link
Owner

skylot commented Mar 8, 2021

Thanks @bagipro! PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants