Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add frida action to copy methods/classes as frida snippets #1356

Merged
merged 2 commits into from
Jan 24, 2022

Conversation

eybisi
Copy link
Contributor

@eybisi eybisi commented Jan 24, 2022

PR for #1355.
Adds Copy as frida snippet option to code area popup.

  • Adds correct overload signature to function snippets.
  • Adds arguments (with names) as function parameter.
  • Tracks which class definition already given to user. ( no duplicate definitions )
  • Inserts kinda dummy information logging to function body.
  • Inserts $ to inner class names so frida will be happy.

@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2022

This pull request introduces 1 alert when merging 9014ba6 into bd4509f - view on LGTM.com

new alerts:

  • 1 for Equals on incomparable types

@skylot skylot merged commit ae5c003 into skylot:master Jan 24, 2022
@skylot
Copy link
Owner

skylot commented Jan 24, 2022

@eybisi thanks!

@jpstotz
Copy link
Collaborator

jpstotz commented Jan 25, 2022

This PR has one major mistake: The created frida snippet uses the deobfuscated class names which only exist in Jadx, instead of the real class names.

@skylot
Copy link
Owner

skylot commented Jan 25, 2022

@jpstotz oh, I see. Funny that class copy uses correct name.
Anyway, it is better to use ClassInfo.getRawName() to get class name used in bytecode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants