Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add xposedscript #1383

Merged
merged 9 commits into from
Feb 18, 2022
Merged

add xposedscript #1383

merged 9 commits into from
Feb 18, 2022

Conversation

MinghaoLin2000
Copy link
Contributor

Because I see it can create frida script, so why not try to create xposed which is also a excellent tool. so I did it. But I have a problem about I can't use the keyboard to use it. Maybe you can add it. Thank you! jadx is good tools~

@skylot
Copy link
Owner

skylot commented Feb 17, 2022

@YenKoc thanks! I commit minor code changes, so it is fine for me.
Can anyone also check this change? 🙂

@oriori1703
Copy link
Contributor

Looks alright, but I have some more changes I would like to suggests.
I'm quite new to Github, so I'm not sure how to add code to an existing PR. can you help me?

@MinghaoLin2000
Copy link
Contributor Author

Looks alright, but I have some more changes I would like to suggests. I'm quite new to Github, so I'm not sure how to add code to an existing PR. can you help me?

sorry. I don't know how to add code in existing PR. It is a little embarrassing.

@MinghaoLin2000
Copy link
Contributor Author

@YenKoc thanks! I commit minor code changes, so it is fine for me. Can anyone also check this change? 🙂

thank you! I don't have see the changes in the current branch. It need some times? I can't wait for using it. It will be useful.

@jpstotz
Copy link
Collaborator

jpstotz commented Feb 18, 2022

sorry. I don't know how to add code in existing PR. It is a little embarrassing.

YenKoc If you push new commits to your master branch (the branch linked to this PR) they will automatically appear in this pull request. A GitHub pull request does not include code or changes, it only mentions the GIT source branch and the destination branch, and the "file changes" are then calculated based on the current content of both branches.

Therefore most users create a separate branch for a PR.

@oriori1703
Copy link
Contributor

oriori1703 commented Feb 18, 2022

@YenKoc I just opened a PR in you fork

@MinghaoLin2000
Copy link
Contributor Author

@YenKoc I just opened a PR in you fork
sorry,i'm so busy that i can't see the pr today. Now I appove it. thanks!

@MinghaoLin2000
Copy link
Contributor Author

@YenKoc I just opened a PR in you fork
I pull request the newest versions. Thanks!

@skylot
Copy link
Owner

skylot commented Feb 18, 2022

@oriori1703 this is a little weird to have PR inside another PR. Please don't do this again 😕
Depending on the size of changes you wish to apply, it is better to make a new PR after this one got merged.
Anyway, everything is already mixed, so I will merge it because changes are good.

Also, for the record, I can push changes into a branch linked to PR (if owner not forbid this).
For any small changes, I can take commit from anyone's fork and move it into PR, so there is no need to open PR in the fork.

@skylot
Copy link
Owner

skylot commented Feb 18, 2022

@oriori1703 and looks like you open another PR in @YenKoc fork ;(
Let not disturb @YenKoc. I will move your commit into this PR (so you can close that PR).

@oriori1703
Copy link
Contributor

@oriori1703 and looks like you open another PR in @YenKoc fork ;( Let not disturb @YenKoc. I will move your commit into this PR (so you can close that PR).

@skylot Sure, sorry for making a mess with all of the PRs.
I will know for next time.

@skylot skylot merged commit 3c2c198 into skylot:master Feb 18, 2022
@skylot
Copy link
Owner

skylot commented Feb 18, 2022

Thanks everyone to your work! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants