Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog for showing exception details and creating an GitHub issue #1399

Merged
merged 5 commits into from
Mar 1, 2022

Conversation

jpstotz
Copy link
Collaborator

@jpstotz jpstotz commented Mar 1, 2022

I have create a simple dialog that shows system and program details as well as the stack trace.

Also a link for creating an issue here at Github is integrated.

image

To test the dialog in the dev version the about menu shows a new action for generating a sample exception that is displayed using the new dialog.

The code is currently not very clean, and the dialog may need some minor improvements regarding placement of UI elements, therefore I create this as draft PR.

@skylot
Copy link
Owner

skylot commented Mar 1, 2022

@jpstotz looks great! I think current version is ready for merge 🙂

@jpstotz jpstotz marked this pull request as ready for review March 1, 2022 13:53
@jpstotz
Copy link
Collaborator Author

jpstotz commented Mar 1, 2022

@skylot I my opinion the PR is ready to be merged.

@skylot skylot merged commit 17fbc99 into skylot:master Mar 1, 2022
@jpstotz jpstotz deleted the exDialog branch March 21, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants