fix(gui): editor theme loading and error/fallback handling improved #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 9a7eaf8 into a717392 - view on LGTM.com new alerts:
|
skylot
approved these changes
May 8, 2022
|
@jpstotz thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #1476.
After calling
MainWindow.setEditorThemeonceMainWindow.editorThemealways should contain a non-null value.First call of
setEditorThemeis done byloadSettings. Assuming an exception is thrown before so thatsetEditorThemeis never called also means that initialization of MainWindow fails, so there should be no UI and state ofeditorThemefield is no longer relevant.