Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

german update #1554

Merged
merged 3 commits into from
Jul 27, 2022
Merged

german update #1554

merged 3 commits into from
Jul 27, 2022

Conversation

Henry2o1o
Copy link
Contributor

❗ Please review the guidelines for contributing

Description

Please describe your pull request.
Reference issue it fixes.

@skylot skylot requested a review from jpstotz June 25, 2022 19:16
@skylot
Copy link
Owner

skylot commented Jul 7, 2022

@jpstotz, @Henry2o1o can I merge this PR?
It is hard for me to follow your discussion, so I just hope you will come to the conclusion 🙂
Another option: I merge as is, and later someone will fix minor issues.

@jpstotz
Copy link
Collaborator

jpstotz commented Jul 8, 2022

@Henry2o1o Could you please apply the changes we agreed on so that skylot can merge this PR?

@skylot
Copy link
Owner

skylot commented Jul 27, 2022

So, no reply from @Henry2o1o 😢

@jpstotz maybe you can add suggestions (like mentioned here in pt. 7), so I will be able to apply these changes and finally merge this PR 🙂

Copy link
Collaborator

@jpstotz jpstotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skylot An interesting way to modify the PR. I took the traditional way, by checking out the PR and then pushing it back to Henry2o1o:patch-8

@skylot
Copy link
Owner

skylot commented Jul 27, 2022

@jpstotz great, thanks!

pushing it back to Henry2o1o:patch-8

I wasn't sure this available to collaborators, also PR contributor can forbid this, so sometimes it didn't work.
Anyway, thank you for help! 👍

@skylot skylot merged commit 6802f60 into skylot:master Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants