Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1583.
@null
is now restricted to values that have a data type ofTYPE_REFERENCE
.Furthermore I restricted the attribute name replacement to
TYPE_INT_DEC
values, in my tests only attributes with that type had a successful replacement, all the other just caused aNumberFormatException
.I compared the resources of several apps decompiled by Jadx and by apktool regarding
@null
replacement. Most apps had the same reference counter of@null
in both decompiled apps. Some apktool decompiled apps had a few references more but I wasn't able to detect where the exact difference was located as the xml files are often named differently and the attributes are created in a different order which makes comparison difficult.Last but not least I noticed that deobfuscator had a rule for abstract classes but not for interfaces.