Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple fix to duplicate/overlapping logcat windows. #1761

Merged
merged 3 commits into from
Jan 21, 2023
Merged

Simple fix to duplicate/overlapping logcat windows. #1761

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0561946
Simple fix to duplicate/overlapping logcat windows. Could be improved…
Jan 9, 2023
394d422
Apply suggestions from code review
skylot Jan 18, 2023
d6b1e4f
Another try to fix trailing spaces using GitHub suggestions
skylot Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions jadx-gui/src/main/java/jadx/gui/ui/panel/LogcatPanel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,9 @@ public void actionPerformed(ActionEvent e) {
};

public boolean showLogcat() {

this.removeAll();

skylot marked this conversation as resolved.
Show resolved Hide resolved
ArrayList<String> pkgs = new ArrayList<>();
pids = new ArrayList<>();
JPanel procBox;
Expand All @@ -112,7 +115,7 @@ public boolean showLogcat() {
NLS.str("logcat.fatal"),
NLS.str("logcat.silent") };
Integer[] msgIndex = { 1, 2, 3, 4, 5, 6, 7, 8 };

skylot marked this conversation as resolved.
Show resolved Hide resolved
this.setLayout(new BorderLayout());
skylot marked this conversation as resolved.
Show resolved Hide resolved
logcatPane = new JTextPane();
logcatPane.setEditable(false);
Expand All @@ -132,7 +135,7 @@ public boolean showLogcat() {
menuPanel.add(pauseButton);
menuPanel.add(Box.createRigidArea(new Dimension(5, 0)));
menuPanel.add(clearButton);

skylot marked this conversation as resolved.
Show resolved Hide resolved
this.add(menuPanel, BorderLayout.NORTH);
skylot marked this conversation as resolved.
Show resolved Hide resolved
this.add(logcatScroll, BorderLayout.CENTER);

Expand Down