Various UI improvements #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jpstotz
commented
Dec 27, 2018
jpstotz
commented
- Enable multi-threaded decompiling
- Added preference for exclude certain packages from decompiling and indexing
- Show message dialog in case classes are not indexed because of low memory (just a warning in the log is IMHO a bit too less. I was personally very surprised when I saw the code for skipping class indexing in Jadx)
- Added preference for disabling indexing skipping because of low memory (for those people that are relying on the fact that all classes has been indexed
Enable multi-threaded decompiling Added preference for exclude certain packages from decompiling and indexing Show message dialog in case classes are not indexed because of low memory (just a warning in the log is IMHO a bit too less) Added preference for disabling indexing skipping because of low memory
skylot
reviewed
Dec 27, 2018
|
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
fix: setting "skipClassIndexingIfLowMemory" removed
fix: setting "skipClassIndexingIfLowMemory" removed
|
@jpstotz thanks! I merged your commits. |
|
🎉 This PR is included in version 0.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Feb 12, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.