chore(core): resource XML generation for parent attribute added #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix! |
|
@skylot adding |
|
@jpstotz can you make a PR for that fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added the missing functionality identified in #931
@skylot I am not sure why but I had some serious problems with the
gradlew check -x testtest. Unless I make a clean before executing this the test very often fails because of format violations in the:spotlessMisctest for the filesjadx-cli\build\reports\checkstyle\*.xml(e.g. main.xml).I am not sure if the test is designed to also include the build directory (hence generated files), I would have assumed it is only for checking src files. Is it possible to exclude the build directories from code style tests?