Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for polling a Kubernetes Master server #91

Merged
merged 7 commits into from
Oct 16, 2014

Conversation

bketelsen
Copy link
Member

This PR adds support for polling a Kubernetes master server and adding new Kubernetes services as SkyDNS A records. SRV records are also resolved with appropriate port numbers.

This support is rudimentary, and needs some refactoring, especially if we intend to support more backends in the future.

@@ -432,6 +432,37 @@ in the etcd backend so a restart of SkyDNS with the same unique value will give

;; ANSWER SECTION:
local.dns.skydns.local. 3600 IN A 192.0.2.1
## Kubernetes
SkyDNS now has primitive support for watching the API of a Kubernetes master and
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why primitive

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because their service definitions are evolving, eventually they will have more things published other than services, we'll support those as they come.

@miekg
Copy link

miekg commented Oct 16, 2014

Looks Good. Let's just evolve these and see how and when this needs re-factoring.

@bketelsen
Copy link
Member Author

PTAL

@bketelsen
Copy link
Member Author

Merge approved by email.

bketelsen added a commit that referenced this pull request Oct 16, 2014
Add support for polling a Kubernetes Master server
@bketelsen bketelsen merged commit 30201d7 into skynetservices:master Oct 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants