-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Catalog with skypilot#1204 #2
Conversation
A thought for future: it may be interesting for the fetchers to print out a report to say: N new instance types; on-demand: N prices have changed in M zones; spot: … etc. This can be useful to put in this repository’s readme or put in SkyPilot’s release notes. |
The following are the updates in the new catalog, where
|
Should this be updating v2 vs. adding a v3? @WoosukKwon |
@concretevitamin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Michaelvll for submitting this PR! I've tested some instances and they worked well.
Since there are some new instance info (InstanceType, Region, AvailabilityZone), does this mean an “older” v2 can’t launch some of these, while a “newer” v2 suddenly can? From a user’s perspective this seems a bit weird. |
@concretevitamin Oh I just realized that the schema has changed. Considering the discussion we had on the v1 -> v2 update, we should bump up the schema version. |
Good point! I just bumped it up to v3. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's merge this!
skypilot#1204