Handle null usage intervals in duration computing #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
reviewed
Feb 8, 2023
sky/global_user_state.py
Outdated
| @@ -426,11 +426,16 @@ def _get_cluster_launch_time(cluster_hash: str) -> Optional[Dict[str, Any]]: | |||
|
|
|||
|
|
|||
| def _get_cluster_duration(cluster_hash: str) -> Optional[Dict[str, Any]]: | |||
There was a problem hiding this comment.
should we update the return value type hint?
sky/global_user_state.py
Outdated
Comment on lines
437
to
438
| if start_time is None: | ||
| continue |
There was a problem hiding this comment.
In what case will the start_time be None? Worth adding a comment for this.
There was a problem hiding this comment.
I guess there is no specific case where this would happen, so I can remove this logic
Michaelvll
approved these changes
Feb 9, 2023
There was a problem hiding this comment.
Thanks for the quick fix @sumanthgenz! LGTM. Due to the GitHub CI changes, please merge the master branch and push again to enable the PR merge.
sumanthgenz
force-pushed
the
sgurram_cost_report_backwards_compatibility
branch
from
2fcb9e6 to
8269594
Compare
sumanthgenz
added a commit
to sumanthgenz/skypilot
that referenced
this pull request
Feb 22, 2023
* handle null usage intervals in duration computing * pr changes --------- Co-authored-by: Sumanth <sumanth@MacBook-Pro-5.local>
sumanthgenz
added a commit
to sumanthgenz/skypilot
that referenced
this pull request
Mar 15, 2023
* handle null usage intervals in duration computing * pr changes --------- Co-authored-by: Sumanth <sumanth@MacBook-Pro-5.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For clusters that are very old and have no history due to being present before changes to
cluster_historytracking forsky cost-report, we return zero duration and cost as a form of error-handling.Tested (run the relevant ones):
Simulated null usage intervals and start times and triggered the error-handling as seen below: