Improve ssh key name handling for Lambda #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
reviewed
Apr 5, 2023
There was a problem hiding this comment.
Thank you for fixing the issues @ewzeng! It looks good to me. Left several questions. : )
Michaelvll
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Thanks for the fixes @ewzeng! LGTM. Left a nit for improving our robustness.
Comment on lines
+259
to
+267
| # Occasionally, the head node will continue running for a short | ||
| # period after termination. This can lead to the following bug: | ||
| # 1. Head node autodowns but continues running. | ||
| # 2. The next autodown event is triggered, which executes ray up. | ||
| # 3. Head node stops running. | ||
| # In this case, a new head node is created after the cluster has | ||
| # terminated. We avoid this with the following check: | ||
| if self.on_head: | ||
| raise lambda_utils.LambdaCloudError('Head already exists.') |
There was a problem hiding this comment.
Should we consider exiting the skylet event or resetting the autodown config as well, to make sure this problem will not happen to the other clouds?
There was a problem hiding this comment.
Hmmm. This might be a good idea. How about I add this in a separate PR?
This was referenced Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes #1836 and #1837 by improving how we handle the ssh key name. We no longer use the ssh key name in
lambda_keysand query Lambda Cloud instead (they have a new API for this). We also improve some error handling code when there is no ip address.Tested:
pytest tests/test_smoke.py --lambdasky launch --cloud lambda --num-nodes 2on a gcp clustersky launch --cloud lambdaafter deletingssh key namefromlambda_keys