Fix: Allow credential files with the same basename. #2042
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With OCI supported and enabled, I encountered the following error on every
sky launch
:The root cause is because both
~/.oci/config
and~/.azure/config
exist locally, and our previous file_mounts optimization couldn't handle basename conflicts.Fixed by using uuids as basename when doing the file_mounts optimization.
Tested (run the relevant ones):
pytest tests/test_smoke.py
: runningpytest tests/test_smoke.py::test_fill_in_the_name
bash tests/backward_comaptibility_tests.sh