-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] Truncate long command str in sky storage ls
#2177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we should add -a
option for sky storage ls
as well if we are going to truncate COMMAND
as a default. -a
, --all
would allow the user to see the full COMMAND
. sky launch
command with task yaml and some options used will always get truncated.
@landscapepainter good idea - added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the support for --all
@romilbhardwaj ! I tested out the flag and this should be ready to go after adding the support in the doc, docs/source/reference/cli.rst
, for the newly added flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! @romilbhardwaj
Truncates long
COMMAND
strs insky storage ls
, like we do insky status
.Before:
After:
Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py::TestStorageWithCredentials