Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serve] Support env var in service yaml #3078

Merged
merged 6 commits into from
Feb 8, 2024
Merged

[Serve] Support env var in service yaml #3078

merged 6 commits into from
Feb 8, 2024

Conversation

dtran24
Copy link
Contributor

@dtran24 dtran24 commented Feb 4, 2024 •
edited
Loading

Fixes #3048

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • Run sky serve with environment variable used in readiness_probe in service yaml (e.g. readiness_probe: /${VERSION}/models)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@dtran24 dtran24 marked this pull request as ready for review February 4, 2024 05:01
@dtran24 dtran24 changed the title [SkyServe] Support env var in service yaml [Serve] Support env var in service yaml Feb 4, 2024
@dtran24
Copy link
Contributor Author

dtran24 commented Feb 4, 2024

Requesting review @cblmemo @MaoZiming 🫡

MaoZiming
MaoZiming reviewed Feb 4, 2024
View reviewed changes
sky/task.py Show resolved Hide resolved
MaoZiming
MaoZiming reviewed Feb 4, 2024
View reviewed changes
sky/task.py Outdated Show resolved Hide resolved
MaoZiming
MaoZiming reviewed Feb 4, 2024
View reviewed changes
sky/task.py Outdated Show resolved Hide resolved
cblmemo
cblmemo reviewed Feb 4, 2024
View reviewed changes
Copy link
Collaborator

@cblmemo cblmemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this feature! Could you add some tests you have run? Ideally we should have a new smoke test for this feature, e.g. a openai chat completion readiness probe.

sky/task.py Outdated Show resolved Hide resolved
@Michaelvll Michaelvll added this to the v0.5 milestone Feb 7, 2024
cblmemo
cblmemo approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@cblmemo cblmemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀 LGTM. Will merge when all unittest are finished.

@cblmemo cblmemo merged commit 49bffa4 into skypilot-org:master Feb 8, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaoZiming MaoZiming MaoZiming left review comments

@cblmemo cblmemo cblmemo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5
Development

Successfully merging this pull request may close these issues.

[Serve] Support env var in service field
4 participants
@dtran24 @MaoZiming @cblmemo @Michaelvll