-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Use original ray path instead of using python dir for ray path #3339
Conversation
Thanks @Michaelvll! I can confirm it works with the base image (
EDIT - I was running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand the problem & fix. Q: why did this issue show up in K8s but not on cloud VM tests?
Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>
Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>
Just updated the PR description: "The issue was caused by the ray package in our kubernetes default image being installed in ~/.local/bin instead of the same dir as python /opt/conda/bin which is likely due to some write permission issue." |
Fixes #3335
The issue was caused by the ray package in our kubernetes default image being installed in
~/.local/bin
instead of the same dir as python/opt/conda/bin
which is likely due to some write permission issue. We now use the original ray path by saving the executable path in a file.Tested (run the relevant ones):
bash format.sh
sky launch
fails on k8s withbash: /opt/conda/bin/ray: No such file or directory
#3335pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
bash tests/backward_comaptibility_tests.sh