Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Allow a very long user program #3512

Merged
merged 4 commits into from
May 7, 2024
Merged

[Core] Allow a very long user program #3512

merged 4 commits into from
May 7, 2024

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented May 6, 2024 •
edited
Loading

Fixes #3511

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@Michaelvll Michaelvll requested a review from cblmemo May 6, 2024 22:47
cblmemo
cblmemo approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@cblmemo cblmemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting and fixing this @Michaelvll ! LGTM. Left 2 nits

sky/backends/cloud_vm_ray_backend.py Outdated Show resolved Hide resolved
sky/backends/cloud_vm_ray_backend.py Outdated Show resolved Hide resolved
Michaelvll and others added 2 commits May 7, 2024 01:55
@Michaelvll @cblmemo
Update sky/backends/cloud_vm_ray_backend.py
dc3e04c 
Co-authored-by: Tian Xia <cblmemo@gmail.com>
@Michaelvll @cblmemo
Update sky/backends/cloud_vm_ray_backend.py
6f9c2fc 
Co-authored-by: Tian Xia <cblmemo@gmail.com>
@Michaelvll Michaelvll merged commit 071614a into master May 7, 2024
20 checks passed
@Michaelvll Michaelvll deleted the allow-long-user-program branch May 7, 2024 20:49
@Michaelvll Michaelvll mentioned this pull request Aug 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblmemo cblmemo cblmemo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Core] Task fails when run section is to long
2 participants
@Michaelvll @cblmemo