Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance] Use new Azure custom images #4167

Merged
merged 3 commits into from
Oct 25, 2024
Merged

[Performance] Use new Azure custom images #4167

merged 3 commits into from
Oct 25, 2024

Conversation

yika-luo
Copy link
Collaborator

@yika-luo yika-luo commented Oct 24, 2024

Use the new custom image for Azure's VM creation.

Example performance change (with fixed region):

VM Type πŸ’» Old Provision πŸ• New Provision πŸ• % Speedup βœ…
Azure GPU 4min 2min 40s 35% (1.5x)
Azure CPU 4min 2min 50% (2x)

Example benchmark commands:
CPU: time sky launch --cloud=azure --region=centralus -y
GPU: time sky launch --cloud=azure --region=centralus -y --gpus=A100-80GB:1

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Relevant individual smoke tests:
    pytest tests/test_smoke.py::test_minimal --azure
    pytest tests/test_smoke.py::test_huggingface --azure
    pytest tests/test_smoke.py::test_job_queue_with_docker --azure
    pytest tests/test_smoke.py::test_cancel_azure

@yika-luo yika-luo changed the title use sky images for azure [Performance] Use new Azure custom images Oct 24, 2024
@yika-luo yika-luo requested a review from Michaelvll October 24, 2024 21:51
Base automatically changed from az-img-process to master October 25, 2024 03:15
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @yika-luo!

@yika-luo yika-luo added this pull request to the merge queue Oct 25, 2024
Merged via the queue into master with commit ee708e7 Oct 25, 2024
20 checks passed
@yika-luo yika-luo deleted the az branch October 25, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants