Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Fix smoke tests for new job creation log format #4325

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

andylizf
Copy link
Contributor

@andylizf andylizf commented Nov 11, 2024

Fix smoke tests that were broken by #4198 which changed the job creation log format. The following tests were updated:

  • test_minimal
  • test_launch_fast
  • test_launch_fast_with_autostop

The tests now validate the new log format where "Job ID" appears before "Useful Commands".

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • pytest tests/test_smoke.py::test_minimal --gcp -v -s
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

Copy link
Collaborator

@cblmemo cblmemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andylizf ! LGTM.

@cblmemo cblmemo added this pull request to the merge queue Nov 11, 2024
Merged via the queue into skypilot-org:master with commit 2540c9f Nov 11, 2024
20 checks passed
@cblmemo cblmemo deleted the fix-smoke-tests branch November 11, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants