Storage Delete for GCP >= 256 Objects #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelzhiluo
requested review from
infwinston,
romilbhardwaj,
Michaelvll and
concretevitamin
michaelzhiluo
force-pushed
the
storage_gcp_delete
branch
from
ba16ab6 to
07f3b0c
Compare
sky/data/storage.py
Outdated
| logger.info(str_line) | ||
| retcode = process.wait() | ||
| if retcode != 0: | ||
| raise exceptions.StorageBucketDeleteError( |
There was a problem hiding this comment.
I believe this is defined in #888. Maybe we should merge this PR after that or rebase this PR?
There was a problem hiding this comment.
After the code base reduction, its kind of hard to rebase and merge different branches. For simplicity, I think let's just merge this PR after #888!
suquark
force-pushed
the
storage_gcp_delete
branch
from
391dca6 to
214091d
Compare
|
Thanks Romil for the review! PTAL |
romilbhardwaj
approved these changes
Jun 6, 2022
suquark
pushed a commit
that referenced
this pull request
Jun 7, 2022
* Fix Weilin's bug * Refactor os.system to subprocess * Addressed romil's comments
suquark
pushed a commit
that referenced
this pull request
Jun 7, 2022
* Fix Weilin's bug * Refactor os.system to subprocess * Addressed romil's comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #724. Now, GCP storage code will detect if the bucket has >=256 objects. If there are more than 256 objects, then it will delete the contents in the bucket first.
Tests
touch ~/Downloads/hallo/{0001..0258}.cYAML file
sky launch -c hallo storage.yaml && sky storage delete michaels-new-bucket-1