Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added the possibility of skipping lines for discord-embed-field titles #428

Merged
merged 2 commits into from
Jul 27, 2024
Merged

fix: added the possibility of skipping lines for discord-embed-field titles #428

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
939e23d
Update DiscordEmbedField.ts
eumarciel404 Jul 27, 2024
3a12132
fix: Removing span tag inside the div tag
eumarciel404 Jul 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 27 additions & 10 deletions packages/core/src/components/discord-embed-field/DiscordEmbedField.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { consume } from '@lit/context';
import { css, html, LitElement } from 'lit';
import { css, html, LitElement, type TemplateResult } from 'lit';
import { customElement, property } from 'lit/decorators.js';
import { ifDefined } from 'lit/directives/if-defined.js';
import { when } from 'lit/directives/when.js';
Expand Down Expand Up @@ -104,18 +104,35 @@ export class DiscordEmbedField extends LitElement implements LightTheme {
private parseTitle(title?: string) {
if (!title) return null;

const words = title.split(' ');
return words.map((word: string, idx: number) => {
const emoji = getGlobalEmojiUrl(word) ?? this.embedFieldEmojisMap[word] ?? ({} as Emoji);
let el: ReturnType<typeof html> | string;
const el: (TemplateResult<1> | string)[] = [];
let complete = '';

if (emoji.name) {
el = html`<discord-custom-emoji name=${emoji.name} url=${ifDefined(emoji.url)} embed-emoji></discord-custom-emoji>`;
} else {
el = idx < words.length - 1 ? `${word} ` : word;
for (const words of title.split('\n')) {
for (const word of words.split(' ')) {
const emoji = getGlobalEmojiUrl(word) ?? this.embedFieldEmojisMap[word] ?? ({} as Emoji);

if (emoji.name) {
el.push(html`<discord-custom-emoji name=${emoji.name} url=${ifDefined(emoji.url)} embed-emoji></discord-custom-emoji>`);
} else {
complete += `${word} `;
}

if (complete === ' ') {
el.push(html`<br />`);
}
}

el.push(complete);

complete = '';
}

return el.map((wordOrHtmlTemplate) => {
if (typeof wordOrHtmlTemplate === 'string') {
return html`<div>${wordOrHtmlTemplate}</div>`;
}

return el;
return wordOrHtmlTemplate;
});
}
}
Expand Down