[test]: Modify test_sst_build_all() to add checks for first_key and last_key of SST #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyzh
approved these changes
May 25, 2024
darkjh
pushed a commit
to darkjh/mini-lsm
that referenced
this pull request
Aug 13, 2024
…ast_key of SST (skyzh#76) Signed-off-by: Alex Chi <iskyzh@gmail.com> Co-authored-by: shenjiaqi.2769 <shenjiaqi.2769@bytedance.com> Co-authored-by: Alex Chi <iskyzh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, when I implemented W1D5, I found that my code can not pass
test_task2_storage_scan(). It is caused by wrong result returned bysst.first_key()andsst.last_key()because of my missing inSsTableBuilder.build()I think it's better to add checks within
test_sst_build_all()in week1_day4 so that we can ensure the correctness of the SST implementation. What do you think?