Fix Quill.getText not respecting length

slab · Jan 30, 2024 · 50746c4 · 50746c4
1 parent c82a61f
commit 50746c4
Show file tree

Hide file tree

Showing 3 changed files with 40 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 - Fix IME not working correctly in Safari.
 - **Clipboard** Support paste as plain text.
+- Fix `Quill.getText`` not respecting length parameter.
 
 # 2.0.0-beta.1
 

diff --git a/packages/quill/src/core/quill.ts b/packages/quill/src/core/quill.ts
@@ -499,7 +499,7 @@ class Quill {
     length?: number,
   ) {
     if (typeof index === 'number') {
-      length = this.getLength() - index;
+      length = length ?? this.getLength() - index;
     }
     // @ts-expect-error
     [index, length] = overload(index, length);
@@ -513,7 +513,7 @@ class Quill {
     length?: number,
   ): string {
     if (typeof index === 'number') {
-      length = this.getLength() - index;
+      length = length ?? this.getLength() - index;
     }
     // @ts-expect-error
     [index, length] = overload(index, length);

diff --git a/packages/quill/test/unit/core/quill.spec.ts b/packages/quill/test/unit/core/quill.spec.ts
@@ -506,6 +506,43 @@ describe('Quill', () => {
       `);
     });
 
+    test('works when provide index and length', () => {
+      const quill = new Quill(createContainer('<h1>Welcome</h1>'));
+      expect(quill.getText(2, 3)).toMatchInlineSnapshot(`
+        "lco"
+      `);
+    });
+
+    test('works with range', () => {
+      const quill = new Quill(createContainer('<h1>Welcome</h1>'));
+      expect(quill.getText({ index: 1, length: 2 })).toMatchInlineSnapshot(
+        '"el"',
+      );
+    });
+  });
+
+  describe('getSemanticHTML()', () => {
+    test('return all html by default', () => {
+      const quill = new Quill(createContainer('<h1>Welcome</h1>'));
+      expect(quill.getSemanticHTML()).toMatchInlineSnapshot(`
+        "<h1>Welcome</h1>"
+      `);
+    });
+
+    test('works when only provide index', () => {
+      const quill = new Quill(createContainer('<h1>Welcome</h1>'));
+      expect(quill.getSemanticHTML(2)).toMatchInlineSnapshot(`
+        "lcome"
+      `);
+    });
+
+    test('works when provide index and length', () => {
+      const quill = new Quill(createContainer('<h1>Welcome</h1>'));
+      expect(quill.getSemanticHTML(2, 3)).toMatchInlineSnapshot(`
+        "lco"
+      `);
+    });
+
     test('works with range', () => {
       const quill = new Quill(createContainer('<h1>Welcome</h1>'));
       expect(quill.getText({ index: 1, length: 2 })).toMatchInlineSnapshot(