Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new link fails #1073

Closed
metsavir opened this issue Oct 24, 2016 · 1 comment
Closed

Adding a new link fails #1073

metsavir opened this issue Oct 24, 2016 · 1 comment

Comments

@metsavir
Copy link

When a link is added right after checking some other link's URL, checked link is updated. Adding a new link fails.

Steps for Reproduction

  1. Visit http://quilljs.com/playground/ (add 'link' to the toolbar)
  2. Write link1 link2
  3. Select link1 text, click the link button in the toolbar, save
  4. Click link1 text to see the URL
  5. Select link2 text, click the link button in the toolbar, save

Expected behavior:

link2 should be a link to URL link2.

Actual behavior:

link2 isn't a link. link1's URL is now link2.

Platforms:

Google Chrome 53.0.2785.143 (64-bit), OS X El Capitan

Version:

v1.0.6

@benbro
Copy link
Contributor

benbro commented Oct 24, 2016

I can reproduce. Step 4 is the important step.
http://codepen.io/anon/pen/BLrEZY

v1.1.2

@jhchen jhchen closed this as completed in c8a70db Oct 24, 2016
tim-mc pushed a commit to tim-mc/quill that referenced this issue Dec 12, 2016
tim-mc pushed a commit to tim-mc/quill that referenced this issue Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants