Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clipboard fix #2707

Closed
wants to merge 1 commit into from
Closed

clipboard fix #2707

wants to merge 1 commit into from

Conversation

volser
Copy link

@volser volser commented Jul 31, 2019

fix for #2706

@jhchen
Copy link
Member

jhchen commented Aug 9, 2019

What's the test case for this?

@volser
Copy link
Author

volser commented Aug 9, 2019

for example, to linkify pasted text

@volser
Copy link
Author

volser commented Aug 9, 2019

@jhchen
Copy link
Member

jhchen commented Aug 9, 2019

I more meant how is this encountered ex steps for reproducing this issue: https://github.com/quilljs/quill/blob/develop/.github/ISSUE_TEMPLATE.md. I'm not aware that browsers just omit text/html

@volser
Copy link
Author

volser commented Aug 9, 2019

visit:
https://codepen.io/volser/pen/dxgoKw

steps:
https://recordit.co/4RfdMYuQET
(copy/paste some link from text editor)

@jhchen
Copy link
Member

jhchen commented Aug 9, 2019

There's a bug in urlMatcher in the codepen where Delta is not defined. If you add a console.log you can see the function is getting hit. When you have a verifiable reproducible case, please review the contributing guide and follow the issue template to submit an Issue first.

@jhchen jhchen closed this Aug 9, 2019
@volser
Copy link
Author

volser commented Aug 9, 2019

@jhchen sorry, but I don't see console log, when paste from text
https://recordit.co/ooYLoyPP7d

@volser
Copy link
Author

volser commented Aug 11, 2019

@jhchen did you see last video?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants