Fix toolbar button state not updated in some cases #2892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecgibson
force-pushed
the
toolbar-highlight
branch
from
bbde134
to
1248238
Compare
alecgibson
force-pushed
the
toolbar-highlight
branch
2 times, most recently
from
7602d66
to
aee07e4
Compare
This change fixes the following bug:
1. Start with plain text "foo bar" in the editor
2. Highlight "bar" (NB: it's important to select text that's not at
the start)
3. Hit Ctrl+B to apply bold formatting
4. Notice that the bold button in the toolbar doesn't receive the
`ql-active` class, when it should
This appears to happen because the listener on `SCROLL_OPTIMIZE` gets an
incorrect range.
Instead of listening on optimize, we listen for all `EDITOR_CHANGE`
events, which _do_ get the correct range.
alecgibson
force-pushed
the
toolbar-highlight
branch
from
aee07e4
to
1cec67e
Compare
luin
changed the title
luin
pushed a commit
that referenced
this pull request
Feb 13, 2024
Co-authored-by: Alec Gibson <aleckgibson@gmail.com>
luin
pushed a commit
that referenced
this pull request
Feb 13, 2024
Co-authored-by: Alec Gibson <aleckgibson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the following bug:
the start)
ql-activeclass, when it shouldThis appears to happen because the listener on
SCROLL_OPTIMIZEgets anincorrect range.
Instead of listening on optimize, we listen for all
EDITOR_CHANGEevents, which do get the correct range.