Run clipboard matchers against plain text pastes #3530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a duplicate of #2706. This seems to have been a regression for over 3 years now? |
alecgibson
force-pushed
the
plain-text-matchers
branch
from
f763652
to
d65a113
Compare
At the moment, if the clipboard pastes `text/plain` content and no `text/html` content, the `Clipboard.convert()` function will completely skip the matching logic. This is surprising when registering text node clipboard matchers. This change updates the `convert()` function to change the plain text into basic HTML, which is passed through the matchers. The conversion interprets newlines as paragraph `<p>` elements, consistent with Quill's existing behaviour.
alecgibson
force-pushed
the
plain-text-matchers
branch
from
d65a113
to
870c18c
Compare
|
This is a bit conflicted with #3927 where we want to match the target format when user pastes with "Paste and Match Style". I think it's hard to say what is the expected behavior unless browsers provide an API telling us whether the user selects "Paste and Match Style" or the source is a plain text. |
alecgibson
added a commit
to reedsy/quill
that referenced
this pull request
Feb 9, 2024
This is a reimplementation of slab#3530 At the moment, if the clipboard pastes `text/plain` content and no `text/html` content, the `Clipboard.convert()` function will completely skip the matching logic. This is surprising when registering text node clipboard matchers. This change updates the `convert()` function to match the plain text against the plain text matchers, just like we do with HTML. Note that these matchers will run _before_ applying the formats for ["paste and match style"][1], so they won't match an element matchers for the target formatting (which I think should be expected anyway). [1]: slab#3927
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, if the clipboard pastes
text/plaincontent and notext/htmlcontent, theClipboard.convert()function will completelyskip the matching logic.
This is surprising when registering text node clipboard matchers.
This change updates the
convert()function to change the plain textinto basic HTML, which is passed through the matchers.
The conversion interprets newlines as paragraph
<p>elements,consistent with Quill's existing behaviour.