Migrate tests to Vitest #3832
Merged
Migrate tests to Vitest #3832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luin
force-pushed
the
zh-vitest
branch
6 times, most recently
from
19a56a5
to
d03cbaf
Compare
jhchen
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Karma is deprecated and they recommend Web Test Runner, jasmine-browser-runner, Jest, and Vitest.
The first two are not as popular as the later two and they have a much smaller community. Jest only runs in Node env whereas Vitest runs on both Node and browser.
This PR migrated Quill's test framework from Jasmine + Karma to Vitest (browser mode).