Skip to content

Commit

Permalink
Add endpoints for calls.* apis and Type: call in blockkit (#1190)
Browse files Browse the repository at this point in the history
Implement the API methods for the Calls API in Slack
https://api.slack.com/apis/calls

Implemented methods
- `calls.add` - Indicate a new call has been started
- `calls.end` - Indicate to slack that the call has ended
- `calls.info` - Get information about an ongoing slack call object
- `calls.update` - update call information
- `calls.participants.add`
- `calls.participants.remove`

Additionally, I've added the minimal version of `Block{Type: "call",
CallID: string}` which slack recommends/requires be posted back to the
channel https://api.slack.com/apis/calls#post_to_channel.

All implemented functionality is publicly documented. There appear to be
additional attributes on the `type: call` block, however those appear to
be internal values for slack's rendering, so I have left them out. See
this gist for specific responses
https://gist.github.com/winston-stripe/0cac608bd63b42d73a352be53577f7fd

##### Pull Request Guidelines

These are recommendations for pull requests.
They are strictly guidelines to help manage expectations.

##### PR preparation
Run `make pr-prep` from the root of the repository to run formatting,
linting and tests.

##### Should this be an issue instead
- [ ] is it a convenience method? (no new functionality, streamlines
some use case)
- [ ] exposes a previously private type, const, method, etc.
- [ ] is it application specific (caching, retry logic, rate limiting,
etc)
- [ ] is it performance related.

##### API changes

Since API changes have to be maintained they undergo a more detailed
review and are more likely to require changes.

- no tests, if you're adding to the API include at least a single test
of the happy case.
- If you can accomplish your goal without changing the API, then do so.
- dependency changes. updates are okay. adding/removing need
justification.

###### Examples of API changes that do not meet guidelines:
- in library cache for users. caches are use case specific.
- Convenience methods for Sending Messages, update, post, ephemeral,
etc. consider opening an issue instead.

---------

Co-authored-by: Winston Durand <me@winstondurand.com>
  • Loading branch information
winston-stripe and R167 authored Oct 14, 2024
1 parent 447b7cd commit 57aa84d
Show file tree
Hide file tree
Showing 6 changed files with 444 additions and 0 deletions.
1 change: 1 addition & 0 deletions block.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ const (
MBTInput MessageBlockType = "input"
MBTHeader MessageBlockType = "header"
MBTRichText MessageBlockType = "rich_text"
MBTCall MessageBlockType = "call"
MBTVideo MessageBlockType = "video"
)

Expand Down
23 changes: 23 additions & 0 deletions block_call.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
package slack

// CallBlock defines data that is used to display a call in slack.
//
// More Information: https://api.slack.com/apis/calls#post_to_channel
type CallBlock struct {
Type MessageBlockType `json:"type"`
BlockID string `json:"block_id,omitempty"`
CallID string `json:"call_id"`
}

// BlockType returns the type of the block
func (s CallBlock) BlockType() MessageBlockType {
return s.Type
}

// NewFileBlock returns a new instance of a file block
func NewCallBlock(callID string) *CallBlock {
return &CallBlock{
Type: MBTCall,
CallID: callID,
}
}
13 changes: 13 additions & 0 deletions block_call_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package slack

import (
"testing"

"github.com/stretchr/testify/assert"
)

func TestNewCallBlock(t *testing.T) {
callBlock := NewCallBlock("ACallID")
assert.Equal(t, string(callBlock.Type), "call")
assert.Equal(t, callBlock.CallID, "ACallID")
}
2 changes: 2 additions & 0 deletions block_conv.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ func (b *Blocks) UnmarshalJSON(data []byte) error {
block = &RichTextBlock{}
case "section":
block = &SectionBlock{}
case "call":
block = &CallBlock{}
case "video":
block = &VideoBlock{}
default:
Expand Down
216 changes: 216 additions & 0 deletions calls.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,216 @@
package slack

import (
"context"
"encoding/json"
"net/url"
"strconv"
"time"
)

type Call struct {
ID string `json:"id"`
Title string `json:"title"`
DateStart JSONTime `json:"date_start"`
DateEnd JSONTime `json:"date_end"`
ExternalUniqueID string `json:"external_unique_id"`
JoinURL string `json:"join_url"`
DesktopAppJoinURL string `json:"desktop_app_join_url"`
ExternalDisplayID string `json:"external_display_id"`
Participants []CallParticipant `json:"users"`
Channels []string `json:"channels"`
}

// CallParticipant is a thin user representation which has a SlackID, ExternalID, or both.
//
// See: https://api.slack.com/apis/calls#users
type CallParticipant struct {
SlackID string `json:"slack_id,omitempty"`
ExternalID string `json:"external_id,omitempty"`
DisplayName string `json:"display_name,omitempty"`
AvatarURL string `json:"avatar_url,omitempty"`
}

// Valid checks if the CallUser has a is valid with a SlackID or ExternalID or both.
func (u CallParticipant) Valid() bool {
return u.SlackID != "" || u.ExternalID != ""
}

type AddCallParameters struct {
JoinURL string // Required
ExternalUniqueID string // Required
CreatedBy string // Required if using a bot token
Title string
DesktopAppJoinURL string
ExternalDisplayID string
DateStart JSONTime
Participants []CallParticipant
}

type UpdateCallParameters struct {
Title string
DesktopAppJoinURL string
JoinURL string
}

type EndCallParameters struct {
// Duration is the duration of the call in seconds. Omitted if 0.
Duration time.Duration
}

type callResponse struct {
Call Call `json:"call"`
SlackResponse
}

// AddCall adds a new Call to the Slack API.
func (api *Client) AddCall(params AddCallParameters) (Call, error) {
return api.AddCallContext(context.Background(), params)
}

// AddCallContext adds a new Call to the Slack API.
func (api *Client) AddCallContext(ctx context.Context, params AddCallParameters) (Call, error) {
values := url.Values{
"token": {api.token},
"join_url": {params.JoinURL},
"external_unique_id": {params.ExternalUniqueID},
}
if params.CreatedBy != "" {
values.Set("created_by", params.CreatedBy)
}
if params.DateStart != 0 {
values.Set("date_start", strconv.FormatInt(int64(params.DateStart), 10))
}
if params.DesktopAppJoinURL != "" {
values.Set("desktop_app_join_url", params.DesktopAppJoinURL)
}
if params.ExternalDisplayID != "" {
values.Set("external_display_id", params.ExternalDisplayID)
}
if params.Title != "" {
values.Set("title", params.Title)
}
if len(params.Participants) > 0 {
data, err := json.Marshal(params.Participants)
if err != nil {
return Call{}, err
}
values.Set("users", string(data))
}

response := &callResponse{}
if err := api.postMethod(ctx, "calls.add", values, response); err != nil {
return Call{}, err
}

return response.Call, response.Err()
}

// GetCallInfo returns information about a Call.
func (api *Client) GetCall(callID string) (Call, error) {
return api.GetCallContext(context.Background(), callID)
}

// GetCallInfoContext returns information about a Call.
func (api *Client) GetCallContext(ctx context.Context, callID string) (Call, error) {
values := url.Values{
"token": {api.token},
"id": {callID},
}

response := &callResponse{}
if err := api.postMethod(ctx, "calls.info", values, response); err != nil {
return Call{}, err
}
return response.Call, response.Err()
}

func (api *Client) UpdateCall(callID string, params UpdateCallParameters) (Call, error) {
return api.UpdateCallContext(context.Background(), callID, params)
}

// UpdateCallContext updates a Call with the given parameters.
func (api *Client) UpdateCallContext(ctx context.Context, callID string, params UpdateCallParameters) (Call, error) {
values := url.Values{
"token": {api.token},
"id": {callID},
}

if params.DesktopAppJoinURL != "" {
values.Set("desktop_app_join_url", params.DesktopAppJoinURL)
}
if params.JoinURL != "" {
values.Set("join_url", params.JoinURL)
}
if params.Title != "" {
values.Set("title", params.Title)
}

response := &callResponse{}
if err := api.postMethod(ctx, "calls.update", values, response); err != nil {
return Call{}, err
}
return response.Call, response.Err()
}

// EndCall ends a Call.
func (api *Client) EndCall(callID string, params EndCallParameters) error {
return api.EndCallContext(context.Background(), callID, params)
}

// EndCallContext ends a Call.
func (api *Client) EndCallContext(ctx context.Context, callID string, params EndCallParameters) error {
values := url.Values{
"token": {api.token},
"id": {callID},
}

if params.Duration != 0 {
values.Set("duration", strconv.FormatInt(int64(params.Duration.Seconds()), 10))
}

response := &SlackResponse{}
if err := api.postMethod(ctx, "calls.end", values, response); err != nil {
return err
}
return response.Err()
}

// CallAddParticipants adds users to a Call.
func (api *Client) CallAddParticipants(callID string, participants []CallParticipant) error {
return api.CallAddParticipantsContext(context.Background(), callID, participants)
}

// CallAddParticipantsContext adds users to a Call.
func (api *Client) CallAddParticipantsContext(ctx context.Context, callID string, participants []CallParticipant) error {
return api.setCallParticipants(ctx, "calls.participants.add", callID, participants)
}

// CallRemoveParticipants removes users from a Call.
func (api *Client) CallRemoveParticipants(callID string, participants []CallParticipant) error {
return api.CallRemoveParticipantsContext(context.Background(), callID, participants)
}

// CallRemoveParticipantsContext removes users from a Call.
func (api *Client) CallRemoveParticipantsContext(ctx context.Context, callID string, participants []CallParticipant) error {
return api.setCallParticipants(ctx, "calls.participants.remove", callID, participants)
}

func (api *Client) setCallParticipants(ctx context.Context, method, callID string, participants []CallParticipant) error {
values := url.Values{
"token": {api.token},
"id": {callID},
}

data, err := json.Marshal(participants)
if err != nil {
return err
}
values.Set("users", string(data))

response := &SlackResponse{}
if err := api.postMethod(ctx, method, values, response); err != nil {
return err
}
return response.Err()
}
Loading

0 comments on commit 57aa84d

Please sign in to comment.