Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_enterprise_install flag for org wide installation support #1225

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

hussachai
Copy link
Contributor

Introducing the inclusion of the 'is_enterprise_install' parameter in commands, interactions, and oauth2 responses. This flag is essential for facilitating organization-wide installations within the enterprise grid environment. Without this flag, the authentication token mapping process becomes unreliable, as it necessitates attempts with both the enterprise ID and team ID, potentially resulting in unexpected outcomes.

Pull Request Guidelines

These are recommendations for pull requests.
They are strictly guidelines to help manage expectations.

PR preparation

Run make pr-prep from the root of the repository to run formatting, linting and tests.

Should this be an issue instead
  • is it a convenience method? (no new functionality, streamlines some use case)
  • exposes a previously private type, const, method, etc.
  • is it application specific (caching, retry logic, rate limiting, etc)
  • is it performance related.
API changes

Since API changes have to be maintained they undergo a more detailed review and are more likely to require changes.

  • no tests, if you're adding to the API include at least a single test of the happy case.
  • If you can accomplish your goal without changing the API, then do so.
  • dependency changes. updates are okay. adding/removing need justification.
Examples of API changes that do not meet guidelines:
  • in library cache for users. caches are use case specific.
  • Convenience methods for Sending Messages, update, post, ephemeral, etc. consider opening an issue instead.

Copy link
Member

@parsley42 parsley42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parsley42
Copy link
Member

@lololozhkin Any objections? Care to add a review?

@parsley42
Copy link
Member

Sorry slow to get this in; appears to be more complete than #1255

@parsley42 parsley42 merged commit fd5d171 into slack-go:master Feb 10, 2024
4 checks passed
ymotongpoo referenced this pull request in ymotongpoo/opentelemetry-collector-extra Jun 4, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/slack-go/slack](https://github.com/slack-go/slack) |
`v0.12.3` -> `v0.13.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fslack-go%2fslack/v0.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fslack-go%2fslack/v0.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fslack-go%2fslack/v0.12.3/v0.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fslack-go%2fslack/v0.12.3/v0.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>slack-go/slack (github.com/slack-go/slack)</summary>

###
[`v0.13.0`](https://github.com/slack-go/slack/releases/tag/v0.13.0)

[Compare
Source](https://github.com/slack-go/slack/compare/v0.12.5...v0.13.0)

> \[!WARNING]\
> This release includes a breaking change since the last release

#### What's Changed

##### Breaking changes

- Expose `team_id` parameter for use with org-wide app by
[@&#8203;candiduslynx](https://github.com/candiduslynx) in
[https://github.com/slack-go/slack/pull/1283](https://github.com/slack-go/slack/pull/1283):
    Changed interface:
    | Old | New |
    | --- | --- |
| `Client.GetBotInfo(bot string) (*Bot, error)` |
`Client.GetBotInfo(parameters GetBotInfoParameters) (*Bot, error)` |
| `Client.GetBotInfoContext(ctx context.Context, bot string)` |
`Client.GetBotInfoContext(ctx context.Context, parameters
GetBotInfoParameters)` |
| `Client.GetTeamProfile() (*TeamProfile, error)` |
`GetTeamProfile(teamID ...string) (*TeamProfile, error)` |
| `GetTeamProfileContext(ctx context.Context) (*TeamProfile, error)` |
`GetTeamProfileContext(ctx context.Context, teamID ...string)
(*TeamProfile, error)` |
| `Client.GetBillableInfo(user string) (map[string]BillingActive,
error)` | `Client.GetBillableInfo(params GetBillableInfoParams)
(map[string]BillingActive, error)` |
| `Client.GetBillableInfoContext(ctx context.Context, user string)
(map[string]BillingActive, error)` | `Client.GetBillableInfoContext(ctx
context.Context, params GetBillableInfoParams)
(map[string]BillingActive, error)` |
| `Client.GetBillableInfoForTeam() (map[string]BillingActive, error)` |
dropped, use `Client.GetBillableInfo` with empty params |
| `Client.GetBillableInfoForTeamContext(ctx context.Context)
(map[string]BillingActive, error)` | dropped, use
`Client.GetBillableInfoContext` with empty params |

##### Bug fixes

- Block Object: Validate text min and max length by
[@&#8203;Chagui-](https://github.com/Chagui-) in
[https://github.com/slack-go/slack/pull/1273](https://github.com/slack-go/slack/pull/1273)
- fix some typos by [@&#8203;yutasb](https://github.com/yutasb) in
[https://github.com/slack-go/slack/pull/1281](https://github.com/slack-go/slack/pull/1281)

##### Enhancements

- Add missing message option for link_names by
[@&#8203;robbydyer](https://github.com/robbydyer) in
[https://github.com/slack-go/slack/pull/1278](https://github.com/slack-go/slack/pull/1278)
- Expose `team_id` parameter for use with org-wide app by
[@&#8203;candiduslynx](https://github.com/candiduslynx) in
[https://github.com/slack-go/slack/pull/1283](https://github.com/slack-go/slack/pull/1283)

#### New Contributors

- [@&#8203;Chagui-](https://github.com/Chagui-) made their first
contribution in
[https://github.com/slack-go/slack/pull/1273](https://github.com/slack-go/slack/pull/1273)
- [@&#8203;robbydyer](https://github.com/robbydyer) made their first
contribution in
[https://github.com/slack-go/slack/pull/1278](https://github.com/slack-go/slack/pull/1278)
- [@&#8203;yutasb](https://github.com/yutasb) made their first
contribution in
[https://github.com/slack-go/slack/pull/1281](https://github.com/slack-go/slack/pull/1281)
- [@&#8203;candiduslynx](https://github.com/candiduslynx) made their
first contribution in
[https://github.com/slack-go/slack/pull/1283](https://github.com/slack-go/slack/pull/1283)

**Full Changelog**:
slack-go/slack@v0.12.5...v0.13.0

###
[`v0.12.5`](https://github.com/slack-go/slack/releases/tag/v0.12.5)

[Compare
Source](https://github.com/slack-go/slack/compare/v0.12.4...v0.12.5)

#### What's Changed

BUGFIX - deal with "true", true, "false", false.

- Parse string or boolean for SlashCommand.IsEnterpriseInstall by
[@&#8203;kpaulisse](https://github.com/kpaulisse) in
[https://github.com/slack-go/slack/pull/1266](https://github.com/slack-go/slack/pull/1266)

**Full Changelog**:
slack-go/slack@v0.12.4...v0.12.5

###
[`v0.12.4`](https://github.com/slack-go/slack/releases/tag/v0.12.4):
Non-breaking updates roll-up

[Compare
Source](https://github.com/slack-go/slack/compare/v0.12.3...v0.12.4)

#### What's Changed

- chore: unnecessary use of fmt.Sprintf by
[@&#8203;testwill](https://github.com/testwill) in
[https://github.com/slack-go/slack/pull/1212](https://github.com/slack-go/slack/pull/1212)
- Add Video Block by [@&#8203;walkure](https://github.com/walkure) in
[https://github.com/slack-go/slack/pull/1210](https://github.com/slack-go/slack/pull/1210)
- Add connected_team_ids optional field to Conversation by
[@&#8203;zFlabmonsta](https://github.com/zFlabmonsta) in
[https://github.com/slack-go/slack/pull/1253](https://github.com/slack-go/slack/pull/1253)
- Add blocks in slackevents.MessageEvent by
[@&#8203;invzhi](https://github.com/invzhi) in
[https://github.com/slack-go/slack/pull/1227](https://github.com/slack-go/slack/pull/1227)
- Add support for Rich Text Lists by
[@&#8203;daniel-pieper-personio](https://github.com/daniel-pieper-personio)
in
[https://github.com/slack-go/slack/pull/1155](https://github.com/slack-go/slack/pull/1155)
- Add support for Rich Text Input by
[@&#8203;peimanja](https://github.com/peimanja) in
[https://github.com/slack-go/slack/pull/1240](https://github.com/slack-go/slack/pull/1240)
- Fix: always add context to errors during block serde by
[@&#8203;yunginnanet](https://github.com/yunginnanet) in
[https://github.com/slack-go/slack/pull/1259](https://github.com/slack-go/slack/pull/1259)
- Edited field in the app mention event by
[@&#8203;IbirbyZh](https://github.com/IbirbyZh) in
[https://github.com/slack-go/slack/pull/1256](https://github.com/slack-go/slack/pull/1256)
- Expose is_enterprise_install field by
[@&#8203;7ail](https://github.com/7ail) in
[https://github.com/slack-go/slack/pull/1255](https://github.com/slack-go/slack/pull/1255)
- feat: Add the ability to set `URL` on `NewButtonBlockElement` via
`.WithURL()` by [@&#8203;joshbranham](https://github.com/joshbranham)
in
[https://github.com/slack-go/slack/pull/1250](https://github.com/slack-go/slack/pull/1250)
- Add block element type FileInput by
[@&#8203;elct9620](https://github.com/elct9620) in
[https://github.com/slack-go/slack/pull/1249](https://github.com/slack-go/slack/pull/1249)
- Openid connect by
[@&#8203;danielmichaels](https://github.com/danielmichaels) in
[https://github.com/slack-go/slack/pull/1242](https://github.com/slack-go/slack/pull/1242)
- Add is_enterprise_install flag for org wide installation support by
[@&#8203;hussachai](https://github.com/hussachai) in
[https://github.com/slack-go/slack/pull/1225](https://github.com/slack-go/slack/pull/1225)
- Add an example of updating modal by
[@&#8203;KouWakai](https://github.com/KouWakai) in
[https://github.com/slack-go/slack/pull/1142](https://github.com/slack-go/slack/pull/1142)
- add deleted timestamp for deleted msg events by
[@&#8203;zFlabmonsta](https://github.com/zFlabmonsta) in
[https://github.com/slack-go/slack/pull/1261](https://github.com/slack-go/slack/pull/1261)
- Add slack connect events & tests by
[@&#8203;Birtato](https://github.com/Birtato) in
[https://github.com/slack-go/slack/pull/1262](https://github.com/slack-go/slack/pull/1262)
- Add rich_text_quote and rich_text_preformatted by
[@&#8203;rusq](https://github.com/rusq) in
[https://github.com/slack-go/slack/pull/1260](https://github.com/slack-go/slack/pull/1260)

#### New Contributors

- [@&#8203;testwill](https://github.com/testwill) made their first
contribution in
[https://github.com/slack-go/slack/pull/1212](https://github.com/slack-go/slack/pull/1212)
- [@&#8203;walkure](https://github.com/walkure) made their first
contribution in
[https://github.com/slack-go/slack/pull/1210](https://github.com/slack-go/slack/pull/1210)
- [@&#8203;zFlabmonsta](https://github.com/zFlabmonsta) made their
first contribution in
[https://github.com/slack-go/slack/pull/1253](https://github.com/slack-go/slack/pull/1253)
- [@&#8203;invzhi](https://github.com/invzhi) made their first
contribution in
[https://github.com/slack-go/slack/pull/1227](https://github.com/slack-go/slack/pull/1227)
-
[@&#8203;daniel-pieper-personio](https://github.com/daniel-pieper-personio)
made their first contribution in
[https://github.com/slack-go/slack/pull/1155](https://github.com/slack-go/slack/pull/1155)
- [@&#8203;peimanja](https://github.com/peimanja) made their first
contribution in
[https://github.com/slack-go/slack/pull/1240](https://github.com/slack-go/slack/pull/1240)
- [@&#8203;yunginnanet](https://github.com/yunginnanet) made their
first contribution in
[https://github.com/slack-go/slack/pull/1259](https://github.com/slack-go/slack/pull/1259)
- [@&#8203;IbirbyZh](https://github.com/IbirbyZh) made their first
contribution in
[https://github.com/slack-go/slack/pull/1256](https://github.com/slack-go/slack/pull/1256)
- [@&#8203;joshbranham](https://github.com/joshbranham) made their
first contribution in
[https://github.com/slack-go/slack/pull/1250](https://github.com/slack-go/slack/pull/1250)
- [@&#8203;elct9620](https://github.com/elct9620) made their first
contribution in
[https://github.com/slack-go/slack/pull/1249](https://github.com/slack-go/slack/pull/1249)
- [@&#8203;danielmichaels](https://github.com/danielmichaels) made
their first contribution in
[https://github.com/slack-go/slack/pull/1242](https://github.com/slack-go/slack/pull/1242)
- [@&#8203;KouWakai](https://github.com/KouWakai) made their first
contribution in
[https://github.com/slack-go/slack/pull/1142](https://github.com/slack-go/slack/pull/1142)
- [@&#8203;Birtato](https://github.com/Birtato) made their first
contribution in
[https://github.com/slack-go/slack/pull/1262](https://github.com/slack-go/slack/pull/1262)

**Full Changelog**:
slack-go/slack@v0.12.3...v0.12.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ymotongpoo/opentelemetry-collector-extra).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants