Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AuthTestResponse to include bot_id #778

Merged
merged 2 commits into from
Sep 15, 2020
Merged

Update AuthTestResponse to include bot_id #778

merged 2 commits into from
Sep 15, 2020

Conversation

amossc
Copy link
Contributor

@amossc amossc commented Aug 17, 2020

Pull Request Guidelines

This is a fix for #777

Executed make pr-prep

@amossc amossc mentioned this pull request Aug 17, 2020
Merged
@kanata2
Copy link
Member

kanata2 commented Aug 17, 2020

Thanks!
The enterprise_id is included if you use Slack Enterprise Grid.
So please leave this field 🙏

@kanata2 kanata2 added the feedback given When a review has been conducted and awaiting the response from the comitter(s) label Sep 12, 2020
@amossc
Copy link
Contributor Author

amossc commented Sep 15, 2020

Thanks!
The enterprise_id is included if you use Slack Enterprise Grid.
So please leave this field 🙏

Sorry. I added it back and rebased on current master. Will squash when I merge.

kanata2
kanata2 approved these changes Sep 15, 2020
View reviewed changes
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kanata2 kanata2 merged commit 2c3dc70 into slack-go:master Sep 15, 2020
@amossc amossc deleted the missing-bot-id-field branch September 15, 2020 00:56
@kanata2 kanata2 changed the title Update AuthTestResponse to include bot_id instead of enterprise_id Update AuthTestResponse to include bot_id Oct 2, 2020
@kanata2 kanata2 added this to the v0.7.0 milestone Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanata2 kanata2 kanata2 approved these changes

Assignees
No one assigned
Labels
feedback given When a review has been conducted and awaiting the response from the comitter(s)
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@amossc @kanata2