Fix #198: Use a thread for Celluloid, shutdown EM. #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's an example of a CHANGELOG.md entry: * [#224](https://github.com/slack-ruby/slack-ruby-client/pull/224): Fix #198: use a thread for celluloid, shutdown em - [@dblock](https://github.com/dblock).Generated by 🚫 danger |
|
Sounds like a reasonable change. One thing to consider is that a celluloid actor runs on it’s own thread anyway. Celluloid has global state which is very hard to isolate. I commend you on your approach and I will take a more detailed look in about 2 weeks. |
dblock
added a commit
to dblock/slack-ruby-client
that referenced
this pull request
Sep 29, 2018
dblock
added a commit
to dblock/slack-ruby-client
that referenced
this pull request
Sep 30, 2018
dblock
added a commit
that referenced
this pull request
Sep 30, 2018
Replace Thread by Actor, undoing #224.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Celluloid change is probably not the best as we create a thread per client now, but since it's going to be deprecated we can roll with it. Joining the actor from the integration spec didn't work.