Remove rtm.start and start_method configuration #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We get a lot of changes by running the API update tasks, so I left those changes out of this and just removed the |
kstole
force-pushed
the
remove_rtm_start
branch
from
f678f6e to
a6bf887
Compare
kstole
force-pushed
the
remove_rtm_start
branch
from
a6bf887 to
5cb2779
Compare
kstole
commented
Oct 2, 2022
Comment on lines
+38
to
+40
| Style/NumericLiterals: | ||
| Exclude: | ||
| - 'spec/**/*' |
There was a problem hiding this comment.
I'm not sure the best way to disable this just for Unix timestamps so I just disabled it entirely for specs
|
Good stuff, thanks! |
|
Added you here too to maintainers (https://github.com/slack-ruby/slack-ruby-client/invitations), thanks for picking up the overdue update tasks @kstole! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the
rtm.startmethod has been deprecated (and has a response matchingrtm.connect), there is only one method for connecting to the Real Time Messaging API.