Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: don't generate 1-parameter tests for mutually exclusive parameters. #529

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

dblock
Copy link
Collaborator

@dblock dblock commented Dec 1, 2024

Fixes the generator specs failing in #524

@dangerpr-bot
Copy link

1 Warning
⚠️ Unless you're refactoring existing code or improving documentation, please update CHANGELOG.md.

Here's an example of a CHANGELOG.md entry:

* [#529](https://github.com/slack-ruby/slack-ruby-client/pull/529): Fix: don't generate 1-parameter tests for mutually exclusive parameters - [@dblock](https://github.com/dblock).

Generated by 🚫 Danger

@dblock dblock merged commit 9edd5ff into slack-ruby:master Dec 1, 2024
10 checks passed
@dblock dblock deleted the fix-generator branch December 1, 2024 14:20
Copy link

github-actions bot commented Dec 1, 2024

Pull Request Test Coverage Report for Build 12106245390

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.336%

Totals Coverage Status
Change from base Build 11729882498: 0.0%
Covered Lines: 5395
Relevant Lines: 6039

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants