Fix #2242 by upgrading express and its dependencies to newer major ve…

…rsions
slackapi · Sep 27, 2024 · 88ac17f · 88ac17f
1 parent 8529f8f
commit 88ac17f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -50,7 +50,7 @@
     "@types/promise.allsettled": "^1.0.3",
     "@types/tsscmp": "^1.0.0",
     "axios": "^1.7.4",
-    "express": "^4.21.0",
+    "express": "^5.0.0",
     "path-to-regexp": "^8.1.0",
     "promise.allsettled": "^1.0.2",
     "raw-body": "^2.3.3",

diff --git a/src/receivers/ExpressReceiver.spec.ts b/src/receivers/ExpressReceiver.spec.ts
@@ -529,7 +529,7 @@ describe('ExpressReceiver', function () {
         // Act
         const req = { body: { }, url: 'http://localhost/slack/oauth_redirect', method: 'GET' } as Request;
         const resp = { send: () => { } } as Response;
-        (receiver.router as any).handle(req, resp);
+        (receiver.router as any).handle(req, resp, () => {});
 
         // Assert
         assert(handleStub.calledWith(req, resp, callbackOptions), 'installer.handleCallback not called');
@@ -552,7 +552,7 @@ describe('ExpressReceiver', function () {
         // Act
         const req = { body: { }, url: 'http://localhost/slack/oauth_redirect', method: 'GET' } as Request;
         const resp = { send: () => { } } as Response;
-        (receiver.router as any).handle(req, resp);
+        (receiver.router as any).handle(req, resp, () => {});
 
         // Assert
         assert(handleStub.calledWith(req, resp, callbackOptions, sinon.match({ scopes })), 'installer.handleCallback not called');