added oauth tests

slackapi · May 21, 2020 · ebd5e11 · ebd5e11
1 parent e8bd599
commit ebd5e11
Show file tree

Hide file tree

Showing 2 changed files with 44 additions and 4 deletions.
diff --git a/src/App.spec.ts b/src/App.spec.ts
@@ -66,28 +66,61 @@ describe('App', () => {
       assert(authorizeCallback.notCalled, 'Should not call the authorize callback on instantiation');
       assert.instanceOf(app, App);
     });
-    it('should fail without a token for single team authorization or authorize callback', async () => {
+    it('should fail without a token for single team authorization or authorize callback or oauth installer',
+       async () => {
+          // Arrange
+         const App = await importApp(); // tslint:disable-line:variable-name
+
+          // Act
+         try {
+           new App({ signingSecret: '' }); // tslint:disable-line:no-unused-expression
+           assert.fail();
+         } catch (error) {
+            // Assert
+           assert.propertyVal(error, 'code', ErrorCode.AppInitializationError);
+         }
+       });
+    it('should fail when both a token and authorize callback are specified', async () => {
       // Arrange
+      const authorizeCallback = sinon.fake();
       const App = await importApp(); // tslint:disable-line:variable-name
 
       // Act
       try {
-        new App({ signingSecret: '' }); // tslint:disable-line:no-unused-expression
+        // tslint:disable-next-line:no-unused-expression
+        new App({ token: '', authorize: authorizeCallback, signingSecret: '' });
         assert.fail();
       } catch (error) {
         // Assert
         assert.propertyVal(error, 'code', ErrorCode.AppInitializationError);
+        assert(authorizeCallback.notCalled);
       }
     });
-    it('should fail when both a token and authorize callback are specified', async () => {
+    it('should fail when both a token is specified and OAuthInstaller is initialized', async () => {
       // Arrange
       const authorizeCallback = sinon.fake();
       const App = await importApp(); // tslint:disable-line:variable-name
 
       // Act
       try {
         // tslint:disable-next-line:no-unused-expression
-        new App({ token: '', authorize: authorizeCallback, signingSecret: '' });
+        new App({ token: '', clientId: '', clientSecret: '', stateSecret: '', signingSecret: '' });
+        assert.fail();
+      } catch (error) {
+        // Assert
+        assert.propertyVal(error, 'code', ErrorCode.AppInitializationError);
+        assert(authorizeCallback.notCalled);
+      }
+    });
+    it('should fail when both a authorize callback is specified and OAuthInstaller is initialized', async () => {
+      // Arrange
+      const authorizeCallback = sinon.fake();
+      const App = await importApp(); // tslint:disable-line:variable-name
+
+      // Act
+      try {
+        // tslint:disable-next-line:no-unused-expression
+        new App({ authorize: authorizeCallback, clientId: '', clientSecret: '', stateSecret: '', signingSecret: '' });
         assert.fail();
       } catch (error) {
         // Assert

diff --git a/src/ExpressReceiver.spec.ts b/src/ExpressReceiver.spec.ts
@@ -41,6 +41,13 @@ describe('ExpressReceiver', () => {
         logger: noopLogger,
         endpoints: { events: '/custom-endpoint' },
         processBeforeResponse: true,
+        clientId: 'my-clientId',
+        clientSecret: 'my-client-secret',
+        stateSecret: 'state-secret',
+        scopes: ['channels:read'],
+        installerOptions: {
+          authVersion: 'v2',
+        },
       });
       assert.isNotNull(receiver);
     });