Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App start() does not account for AWSLambdaReceiver return type #1038

Closed
4 of 10 tasks
srajiang opened this issue Aug 5, 2021 · 0 comments · Fixed by #1039
Closed
4 of 10 tasks

App start() does not account for AWSLambdaReceiver return type #1038

srajiang opened this issue Aug 5, 2021 · 0 comments · Fixed by #1039
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented
Milestone

Comments

@srajiang
Copy link
Member

srajiang commented Aug 5, 2021

Description

App::start return type does not account for AWSLambdaReceiver, causing TS to complain.

Related: #1034

app.start's return type is ReturnType<HTTPReceiver['start']>, which is Promise<Server> (code).

When using bolt-js AWSLambdaReceiver in Typescript, the return type of App::start causes the TS compiler to complain. Users following along with the deploying to aws serverless sample code see this:

image
image

With correct return type Promise<AWSHandler> as defined here, this issue goes away.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • example code related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

Reproducible in:

package version: 3.5.0

node version:

OS version(s):

@gitwave gitwave bot added the untriaged label Aug 5, 2021
@srajiang srajiang added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented and removed untriaged labels Aug 5, 2021
@srajiang srajiang modified the milestone: 3.6.0 Aug 5, 2021
seratch added a commit to seratch/bolt-js that referenced this issue Aug 5, 2021
seratch added a commit to seratch/bolt-js that referenced this issue Aug 5, 2021
@seratch seratch added this to the 3.6.0 milestone Aug 5, 2021
srajiang added a commit that referenced this issue Aug 6, 2021
Fix #1038 by making the AwsLambdaReceiver example TS compatible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants