-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExpressReceiver support for rawBody for signature verification #192
Labels
enhancement
M-T: A feature request for new functionality
Comments
cc @seratch - I think you'd like to follow this issue 😄 |
Did somebody already start working on this? If not, I'll make a pull request soon (possibly this weekend or early next week). |
@seratch nobody has claimed this one yet that we're aware of. the timeline of next week sounds great! i'll assign this one to you just to keep track 🙇 |
seratch
added a commit
to seratch/bolt-js
that referenced
this issue
May 19, 2019
2 tasks
seratch
added a commit
to seratch/bolt-js
that referenced
this issue
May 20, 2019
seratch
added a commit
to seratch/bolt-js
that referenced
this issue
May 21, 2019
seratch
added a commit
to seratch/bolt-js
that referenced
this issue
May 21, 2019
aoberoi
added a commit
that referenced
this issue
May 24, 2019
Fix #192 ExpressReceiver support for rawBody for signature verification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The
ExpressReceiver
handles buffering the request body stream, and then verifying the signature (using the signing secret) in order to authenticate the sender as Slack.However, when running in some serverless environments, such as Google Cloud Platform (GCP), the request body has already been buffered and even parsed before the Receiver gets a chance to interact with it. In GCP, the original buffer is not destroyed, but rather added as the
req.rawBody
property.The
ExpressReceiver
should check thereq.rawBody
property for a buffered body for verification, instead of failing in this condition.This feature request is analogous to slackapi/node-slack-events-api#85, and the fix would be analogous to slackapi/node-slack-events-api#90.
Requirements (place an
x
in each of the[ ]
)The text was updated successfully, but these errors were encountered: